Merge pull request #1081 from lightninglabs/dev/remove-redundant-getinfo

Remove getInfo call from autopilot action

src/action/autopilot.js

@@ -8,10 +8,9 @@ import { poll, checkHttpStatus } from '../helper';
 import * as log from './log';
 
 class AtplAction {
-  constructor(store, grpc, info, db, notification) {
+  constructor(store, grpc, db, notification) {
     this._store = store;
     this._grpc = grpc;
-    this._info = info;
     this._db = db;
     this._notification = notification;
   }
@@ -64,7 +63,7 @@ class AtplAction {
    */
   async updateNodeScores() {
     try {
-      await this._setNetwork();
+      await this._checkNetwork();
       const scores = await this._readNodeScores();
       await this._setNodeScores(scores);
     } catch (err) {
@@ -72,8 +71,7 @@ class AtplAction {
     }
   }
 
-  async _setNetwork() {
-    await this._info.getInfo();
+  async _checkNetwork() {
     if (!this._store.network) {
       throw new Error('Could not read network');
     }

src/action/index-mobile.js

@@ -63,7 +63,7 @@ export const auth = new AuthAction(
   LocalAuthentication,
   Alert
 );
-export const autopilot = new AtplAction(store, grpc, info, db, notify);
+export const autopilot = new AtplAction(store, grpc, db, notify);
 
 payment.listenForUrlMobile(Linking); // enable incoming url handler
 

src/action/index.js

@@ -42,7 +42,7 @@ export const channel = new ChannelAction(store, grpc, nav, notify);
 export const invoice = new InvoiceAction(store, grpc, nav, notify, Clipboard);
 export const payment = new PaymentAction(store, grpc, nav, notify, Clipboard);
 export const setting = new SettingAction(store, wallet, db, ipc);
-export const autopilot = new AtplAction(store, grpc, info, db, notify);
+export const autopilot = new AtplAction(store, grpc, db, notify);
 
 payment.listenForUrl(ipc); // enable incoming url handler
 

test/integration/action/action-integration.spec.js

@@ -167,7 +167,7 @@ describe('Action Integration Tests', function() {
     channels1 = new ChannelAction(store1, grpc1, nav1, notify1);
     invoice1 = new InvoiceAction(store1, grpc1, nav1, notify1);
     payments1 = new PaymentAction(store1, grpc1, nav1, notify1);
-    autopilot1 = new AtplAction(store1, grpc1, info1, db1, notify1);
+    autopilot1 = new AtplAction(store1, grpc1, db1, notify1);
 
     db2 = sinon.createStubInstance(AppStorage);
     nav2 = sinon.createStubInstance(NavAction);
@@ -180,7 +180,7 @@ describe('Action Integration Tests', function() {
     channels2 = new ChannelAction(store2, grpc2, nav2, notify2);
     invoice2 = new InvoiceAction(store2, grpc2, nav2, notify2);
     payments2 = new PaymentAction(store2, grpc2, nav2, notify2);
-    autopilot2 = new AtplAction(store2, grpc2, info2, db2, notify2);
+    autopilot2 = new AtplAction(store2, grpc2, db2, notify2);
 
     sandbox.stub(autopilot1, 'updateNodeScores').resolves(true);
     sandbox.stub(autopilot2, 'updateNodeScores').resolves(true);

test/unit/action/autopilot.spec.js

@@ -2,7 +2,6 @@ import { Store } from '../../../src/store';
 import GrpcAction from '../../../src/action/grpc';
 import NotificationAction from '../../../src/action/notification';
 import AppStorage from '../../../src/action/app-storage';
-import InfoAction from '../../../src/action/info';
 import AtplAction from '../../../src/action/autopilot';
 import * as logger from '../../../src/action/log';
 import nock from 'nock';
@@ -13,7 +12,6 @@ describe('Action Autopilot Unit Test', () => {
   let db;
   let grpc;
   let notify;
-  let info;
   let autopilot;
   let sandbox;
 
@@ -25,8 +23,7 @@ describe('Action Autopilot Unit Test', () => {
     grpc = sinon.createStubInstance(GrpcAction);
     db = sinon.createStubInstance(AppStorage);
     notify = sinon.createStubInstance(NotificationAction);
-    info = sinon.createStubInstance(InfoAction);
-    autopilot = new AtplAction(store, grpc, info, db, notify);
+    autopilot = new AtplAction(store, grpc, db, notify);
   });
 
   afterEach(() => {
@@ -87,7 +84,6 @@ describe('Action Autopilot Unit Test', () => {
           },
         ],
       };
-      info.getInfo.resolves();
       store.network = 'testnet';
     });