Unverified Commit a260c7a9 authored by Alois Mbutura's avatar Alois Mbutura Committed by GitHub

Add note on NUL terminator check for safety

1. Add note on checking for NUL terminator explicitly and adding it if not present. This is done for safety.
parent e09abc83
...@@ -1031,7 +1031,7 @@ static void bytestring_check_then_write(esp_attr_value_t* attribute, prepare_wri ...@@ -1031,7 +1031,7 @@ static void bytestring_check_then_write(esp_attr_value_t* attribute, prepare_wri
if(prepare_write_env->prepare_buf[(prepare_write_env->prepare_len)-1] != '\0') if(prepare_write_env->prepare_buf[(prepare_write_env->prepare_len)-1] != '\0')
{ {
/*Byte array lacks NUL string terminator*/ /*Safety check-Byte array lacks NUL string terminator*/
uint8_t* nul_terminated_buffer=(uint8_t*)malloc((prepare_write_env->prepare_len)+1); uint8_t* nul_terminated_buffer=(uint8_t*)malloc((prepare_write_env->prepare_len)+1);
memcpy(nul_terminated_buffer, prepare_write_env->prepare_buf, prepare_write_env->prepare_len); memcpy(nul_terminated_buffer, prepare_write_env->prepare_buf, prepare_write_env->prepare_len);
nul_terminated_buffer[prepare_write_env->prepare_len] = '\0'; nul_terminated_buffer[prepare_write_env->prepare_len] = '\0';
...@@ -1082,7 +1082,7 @@ static void bytestring_check_then_write(esp_attr_value_t* attribute, prepare_wri ...@@ -1082,7 +1082,7 @@ static void bytestring_check_then_write(esp_attr_value_t* attribute, prepare_wri
} }
else else
{ {
/*Byte array contains NUL string terminator*/ /*Safety check-Byte array contains NUL string terminator*/
invalid = simple_check_UTF8((char*)prepare_write_env->prepare_buf); invalid = simple_check_UTF8((char*)prepare_write_env->prepare_buf);
if(!invalid) if(!invalid)
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment